lkml.org 
[lkml]   [2014]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next v5 1/9] xen-netback: Introduce TX grant map definitions
From
Date
On Mon, 2014-01-20 at 21:24 +0000, Zoltan Kiss wrote:
>
> + spinlock_t dealloc_lock;
> + spinlock_t response_lock;

Please add comments to both of these describing what bits of the
datastructure they are locking.

You might find it is clearer to group the locks and the things they
protect together rather than grouping the locks together.

Ian.



\
 
 \ /
  Last update: 2014-02-18 19:01    [W:0.391 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site