lkml.org 
[lkml]   [2014]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] fs: xattr: Don't display attributes without read access
On Sun, 16 Feb 2014 20:31:01 +0800 Fabian Frederick <fabf@skynet.be> wrote:

> Any user can display extented attribute names without read
> access.
>
> eg: attr -l <filename>
>
> This patch checks inode_permission in listxattr common
> function before executing vfs_listxattr.
>
> ...
>
> --- a/fs/xattr.c
> +++ b/fs/xattr.c
> @@ -543,6 +543,10 @@ listxattr(struct dentry *d, char __user *list, size_t size)
> char *klist = NULL;
> char *vlist = NULL; /* If non-NULL, we used vmalloc() */
>
> + error = inode_permission(d->d_inode, MAY_READ);
> + if (error)
> + return error;
> +
> if (size) {
> if (size > XATTR_LIST_MAX)
> size = XATTR_LIST_MAX;

erk. Doesn't this mean that if existing userspace is relying on the
current behaviour, this patch will cause breakage?



\
 
 \ /
  Last update: 2014-02-19 01:01    [W:0.056 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site