lkml.org 
[lkml]   [2014]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH 1/1] fs: xattr: Don't display attributes without read access
Any user can display extented attribute names without read
access.

eg: attr -l <filename>

This patch checks inode_permission in listxattr common
function before executing vfs_listxattr.

Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
fs/xattr.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/fs/xattr.c b/fs/xattr.c
index 3377dff..d26b280 100644
--- a/fs/xattr.c
+++ b/fs/xattr.c
@@ -543,6 +543,10 @@ listxattr(struct dentry *d, char __user *list, size_t size)
char *klist = NULL;
char *vlist = NULL; /* If non-NULL, we used vmalloc() */

+ error = inode_permission(d->d_inode, MAY_READ);
+ if (error)
+ return error;
+
if (size) {
if (size > XATTR_LIST_MAX)
size = XATTR_LIST_MAX;
--
1.8.1.4


\
 
 \ /
  Last update: 2014-02-16 22:01    [W:0.076 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site