Messages in this thread | | | Date | Wed, 12 Feb 2014 09:17:24 +0000 | From | Lee Jones <> | Subject | Re: [PATCH 08/14] mfd: sec: Add support for S2MPS14 |
| |
> Add support for S2MPS14 PMIC device to the MFD sec-core driver. > The S2MPS14 is similar to S2MPS11 but it has fewer regulators, two > clocks instead of three and a little different registers layout. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- > drivers/mfd/sec-core.c | 48 +++++++++-- > drivers/mfd/sec-irq.c | 89 +++++++++++++++++++- > include/linux/mfd/samsung/core.h | 1 + > include/linux/mfd/samsung/irq.h | 27 +++++++ > include/linux/mfd/samsung/rtc.h | 56 +++++++++++-- > include/linux/mfd/samsung/s2mps14.h | 152 +++++++++++++++++++++++++++++++++++ > 6 files changed, 361 insertions(+), 12 deletions(-) > create mode 100644 include/linux/mfd/samsung/s2mps14.h > > diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
<snip>
> +static const struct mfd_cell s2mps14_devs[] = { > + { > + .name = "s2mps14-pmic", > + }, { > + .name = "s2mps14-rtc", > + }, { > + .name = "s2mps14-clk", > + } > +};
No device tree support for the children?
<Snip>
> +#define S2MPS14_LDO_VSEL_MASK 0x3F > +#define S2MPS14_BUCK_VSEL_MASK 0xFF > +#define S2MPS14_ENABLE_MASK (0x03 << S2MPS14_ENABLE_SHIFT) > +#define S2MPS14_ENABLE_SHIFT 6 > +#define S2MPS14_LDO_N_VOLTAGES (S2MPS14_LDO_VSEL_MASK + 1) > +#define S2MPS14_BUCK_N_VOLTAGES (S2MPS14_BUCK_VSEL_MASK + 1)
Nit: Can you line these up using tabs please?
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |