Messages in this thread | | | Date | Wed, 12 Feb 2014 09:07:46 +0000 | From | Lee Jones <> | Subject | Re: [PATCH 05/14] mfd: sec: Use consistent S2MPS11 RTC alarm interrupt indexes |
| |
> The S2MPS11 RTC has two alarms: alarm0 and alarm1 (corresponding > interrupts are named similarly). Use consistent names for interrupts to > limit possible errors. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- > drivers/mfd/sec-irq.c | 8 ++++---- > include/linux/mfd/samsung/irq.h | 4 ++-- > 2 files changed, 6 insertions(+), 6 deletions(-)
<snip>
> #define S2MPS11_IRQ_RTC60S_MASK (1 << 0) > #define S2MPS11_IRQ_RTCA1_MASK (1 << 1) > -#define S2MPS11_IRQ_RTCA2_MASK (1 << 2) > +#define S2MPS11_IRQ_RTCA0_MASK (1 << 2)
This doesn't look correct to me.
> #define S2MPS11_IRQ_SMPL_MASK (1 << 3) > #define S2MPS11_IRQ_RTC1S_MASK (1 << 4) > #define S2MPS11_IRQ_WTSR_MASK (1 << 5)
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |