Messages in this thread | | | Subject | Re: [PATCH] Make math_state_restore() save and restore the interrupt flag | From | "H. Peter Anvin" <> | Date | Sat, 01 Feb 2014 17:43:57 -0800 |
| |
What does the inner if clause do? It looks like it returns either way...
On February 1, 2014 5:35:13 PM PST, Suresh Siddha <sbsiddha@gmail.com> wrote: >On Sat, Feb 1, 2014 at 5:26 PM, H. Peter Anvin <hpa@zytor.com> wrote: >> Even "b" does that, no? > >oh right. It needs an else. only for non-eager fpu case we should do >stts() > > void __kernel_fpu_end(void) > { > if (use_eager_fpu()) { > struct task_struct *me = current; > > if (tsk_used_math(me) && likely(!restore_fpu_checking( >me))) > return; > } else > stts(); > } > >thanks, >suresh > >> "a" should be fine as long as we don't ever use >> those features in the kernel, even under kernel_fpu_begin/end().
-- Sent from my mobile phone. Please pardon brevity and lack of formatting.
| |