Messages in this thread | | | Date | Sat, 1 Feb 2014 17:38:27 -0800 | Subject | Re: [PATCH] Make math_state_restore() save and restore the interrupt flag | From | Linus Torvalds <> |
| |
On Sat, Feb 1, 2014 at 5:35 PM, Suresh Siddha <sbsiddha@gmail.com> wrote: > On Sat, Feb 1, 2014 at 5:26 PM, H. Peter Anvin <hpa@zytor.com> wrote: >> Even "b" does that, no? > > oh right. It needs an else. only for non-eager fpu case we should do stts()
It definitely does not want an else, I think.
If tsk_used_math() is false, or if the FPU restore failed, we *definitely* need that stts(). Otherwise we'd return to user mode with random contents in the FP state, and let user mode muck around with it.
No?
Linus
| |