lkml.org 
[lkml]   [2014]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tools/liblockdep: Fix debug_check thinko in mutex destroy
On 12/08/2014 06:07 AM, Kirill Smelkov wrote:
> In mutex destroy code currently we pass to debug_check_no_locks_freed()
>
> [mem_from, mem_end)
>
> address region. But debug_check_no_locks_freed() accepts
>
> mem_from, mem_*len*
>
> i.e. second parameter is region length, not end address. And it was
> always so, starting from 2006 (fbb9ce95 "lockdep: core").
>
> Fix it, or else on a mutex destroy we wrongly check
> much-wider-than-mutex region and can find not-yet-released other locks
> there and wrongly report BUGs on them.

Great catch, thanks!


Thanks,
Sasha


\
 
 \ /
  Last update: 2014-12-08 16:21    [W:0.047 / U:0.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site