Messages in this thread Patch in this message | | | Date | Thu, 04 Dec 2014 23:18:41 +0100 | From | SF Markus Elfring <> | Subject | [PATCH v2 5/6] net-PPP: Delete an unnecessary assignment in mppe_alloc() |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Thu, 4 Dec 2014 22:33:34 +0100
The data structure element "arc4" was assigned a null pointer by the mppe_alloc() function if a previous function call "crypto_alloc_blkcipher" failed. This assignment became unnecessary with previous source code adjustments.
Let us delete it from the affected implementation because the element "arc4" will not be accessible outside the function after the detected allocation failure.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/net/ppp/ppp_mppe.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ppp/ppp_mppe.c b/drivers/net/ppp/ppp_mppe.c index c82198f..b7db4b1 100644 --- a/drivers/net/ppp/ppp_mppe.c +++ b/drivers/net/ppp/ppp_mppe.c @@ -204,10 +204,8 @@ static void *mppe_alloc(unsigned char *options, int optlen) state->arc4 = crypto_alloc_blkcipher("ecb(arc4)", 0, CRYPTO_ALG_ASYNC); - if (IS_ERR(state->arc4)) { - state->arc4 = NULL; + if (IS_ERR(state->arc4)) goto out_free; - } state->sha1 = crypto_alloc_hash("sha1", 0, CRYPTO_ALG_ASYNC); if (IS_ERR(state->sha1)) { -- 2.1.3
| |