lkml.org 
[lkml]   [2014]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey()
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 4 Dec 2014 18:28:52 +0100

    The mppe_rekey() function contained a few update candidates.
    * Curly brackets were still used around a single function call "printk".
    * Unwanted space characters

    Let us improve these implementation details according to the current Linux
    coding style convention.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/net/ppp/ppp_mppe.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/net/ppp/ppp_mppe.c b/drivers/net/ppp/ppp_mppe.c
    index 911b216..84b7bce 100644
    --- a/drivers/net/ppp/ppp_mppe.c
    +++ b/drivers/net/ppp/ppp_mppe.c
    @@ -172,9 +172,8 @@ static void mppe_rekey(struct ppp_mppe_state * state, int initial_key)
    setup_sg(sg_in, state->sha1_digest, state->keylen);
    setup_sg(sg_out, state->session_key, state->keylen);
    if (crypto_blkcipher_encrypt(&desc, sg_out, sg_in,
    - state->keylen) != 0) {
    - printk(KERN_WARNING "mppe_rekey: cipher_encrypt failed\n");
    - }
    + state->keylen) != 0)
    + pr_warn("mppe_rekey: cipher_encrypt failed\n");
    } else {
    memcpy(state->session_key, state->sha1_digest, state->keylen);
    }
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-12-04 23:41    [W:5.508 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site