lkml.org 
[lkml]   [2014]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC 3/3] virtio_ccw: rev 1 devices set VIRTIO_F_VERSION_1
On Thu, Dec 04, 2014 at 06:59:14PM +0100, Cornelia Huck wrote:
> On Thu, 4 Dec 2014 19:26:50 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > What does it mean if rev 1 device does not set
> > VIRTIO_F_VERSION_1? E.g. is it native endian?
> >
> > Let's not even try to drive such devices:
> > skip attempts to finalize features or set status.
>
> Why not set status_failed?

It might be cleanest to just teach core that finalize_features
can fail.
I'll look into this.

> > virtio core will detect this and bail out.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > drivers/s390/kvm/virtio_ccw.c | 15 +++++++++++++++
> > 1 file changed, 15 insertions(+)
> >
>
> I'm not sure yet whether I like this approach. I'll think about it over
> the weekend.


\
 
 \ /
  Last update: 2014-12-04 19:41    [W:0.095 / U:0.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site