Messages in this thread | | | Date | Thu, 4 Dec 2014 18:59:14 +0100 | From | Cornelia Huck <> | Subject | Re: [PATCH RFC 3/3] virtio_ccw: rev 1 devices set VIRTIO_F_VERSION_1 |
| |
On Thu, 4 Dec 2014 19:26:50 +0200 "Michael S. Tsirkin" <mst@redhat.com> wrote:
> What does it mean if rev 1 device does not set > VIRTIO_F_VERSION_1? E.g. is it native endian? > > Let's not even try to drive such devices: > skip attempts to finalize features or set status.
Why not set status_failed?
> virtio core will detect this and bail out. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > drivers/s390/kvm/virtio_ccw.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) >
I'm not sure yet whether I like this approach. I'll think about it over the weekend.
| |