Messages in this thread | | | Date | Wed, 31 Dec 2014 21:28:06 +0000 | Subject | Re: [PATCH v2 2/4] staging: rtl8192u: fix whitespace | From | Lorenzo Stoakes <> |
| |
On 31 December 2014 at 21:20, Joe Perches <joe@perches.com> wrote:
> It'd be nicer to use the same form and indentation > for both entries. > > Probably be nicer to use: > > static u32 edca_setting_DL[HT_IOT_PEER_MAX] = { > 0x5e4322, 0x5e4322, 0x5e4322, 0x604322, 0x00a44f, 0x5ea44f > }; > static u32 edca_setting_UL[HT_IOT_PEER_MAX] = { > 0x5e4322, 0x00a44f, 0x5e4322, 0x604322, 0x5ea44f, 0x5ea44f > }; > > so that the entries align too.
Ack... I am a bit of a beginner at the kernel, I think you can tell ;-) I didn't mean for this to have different indentation, in fixing up other issues I missed this one, will fix. Will also add the 00 prefix, good idea (+ update the commit message to accommodate.)
> > Would it be better to use const? >
I think this would be better as a separate patch as that is getting into changing actual semantics rather than just simple style fixes, there is a lot that could be improved here in that realm I think :)
Best, Lorenzo
| |