Messages in this thread | | | Subject | Re: [PATCH v2 2/4] staging: rtl8192u: fix whitespace | From | Joe Perches <> | Date | Wed, 31 Dec 2014 13:20:06 -0800 |
| |
On Wed, 2014-12-31 at 21:10 +0000, Lorenzo Stoakes wrote: > This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace > in r8192U_dm.c and additionally it removes inconsistent whitespace throughout. [] > diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c [] > +static u32 edca_setting_DL[HT_IOT_PEER_MAX] = { > + 0x5e4322, 0x5e4322, 0x5e4322, 0x604322, 0xa44f, 0x5ea44f > +}; > +static u32 edca_setting_UL[HT_IOT_PEER_MAX] = { > + 0x5e4322, 0xa44f, 0x5e4322, 0x604322, 0x5ea44f, 0x5ea44f > +};
It'd be nicer to use the same form and indentation for both entries.
Probably be nicer to use:
static u32 edca_setting_DL[HT_IOT_PEER_MAX] = { 0x5e4322, 0x5e4322, 0x5e4322, 0x604322, 0x00a44f, 0x5ea44f }; static u32 edca_setting_UL[HT_IOT_PEER_MAX] = { 0x5e4322, 0x00a44f, 0x5e4322, 0x604322, 0x5ea44f, 0x5ea44f };
so that the entries align too.
Would it be better to use const?
| |