Messages in this thread | | | Date | Sat, 27 Dec 2014 21:19:49 +0100 | Subject | Re: [PATCH] bcma: fix three coding style issues, more than 80 characters per line | From | Rafał Miłecki <> |
| |
On 27 December 2014 at 20:24, Oscar Forner Martinez <oscar.forner.martinez@gmail.com> wrote: > Three lines with more than 80 characters per line have been split in several lines.
Thanks for the next version :)
1) You missed version number. Something like git format-patch --subject-prefix="PATCH V3" (you saying for the future).
2) I'm OK with your changes, but when checking the patch I get some errors like ERROR: trailing whitespace ERROR: DOS line endings (I used ./scripts/checkpatch.pl, see attached checkpatch log).
I think that "trailing whitespace" errors are caused by DOS line endings, because I don't see anything wrong about your code.
Is there something wrong with your emacs? git-send-email shouldn't malform patches I believe. ERROR: trailing whitespace #62: FILE: drivers/bcma/driver_chipcommon.c:82: +^I^I^I/* 4706 CC and PMU watchdogs are clocked at 1/4 of ALP^M$
ERROR: trailing whitespace #63: FILE: drivers/bcma/driver_chipcommon.c:83: +^I^I^I * clock^M$
ERROR: DOS line endings #64: FILE: drivers/bcma/driver_chipcommon.c:84: +^I^I^I */^M$
ERROR: DOS line endings #73: FILE: drivers/bcma/driver_chipcommon.c:102: +^Iwdt.max_timer_ms =^M$
ERROR: DOS line endings #74: FILE: drivers/bcma/driver_chipcommon.c:103: +^I^Ibcma_chipco_watchdog_get_max_timer(cc) / cc->ticks_per_ms;^M$
ERROR: DOS line endings #83: FILE: drivers/bcma/driver_chipcommon.c:341: +^I^Ibcma_err(cc->core->bus, "serial not supported on this device ccrev: 0x%x\n",^M$
ERROR: DOS line endings #84: FILE: drivers/bcma/driver_chipcommon.c:342: +^I^I^I ccrev);^M$
total: 7 errors, 0 warnings, 28 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or scripts/cleanfile
bcma.patch has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
| |