Messages in this thread | | | Date | Sun, 28 Dec 2014 10:12:19 +0100 | Subject | Re: [PATCH] bcma: fix three coding style issues, more than 80 characters per line | From | Sedat Dilek <> |
| |
On Sun, Dec 28, 2014 at 9:53 AM, Rafał Miłecki <zajec5@gmail.com> wrote: > On 28 December 2014 at 06:50, Sedat Dilek <sedat.dilek@gmail.com> wrote: >> On Sun, Dec 28, 2014 at 12:44 AM, Rafał Miłecki <zajec5@gmail.com> wrote: >>> On 27 December 2014 at 20:24, Oscar Forner Martinez >>> <oscar.forner.martinez@gmail.com> wrote: >>>> Three lines with more than 80 characters per line have been split in several lines. >>>> >>>> Signed-off-by: Oscar Forner Martinez <oscar.forner.martinez@gmail.com> >>> >>> Acked-by: Rafał Miłecki <zajec5@gmail.com> >>> >> >> As for the comment-line changes... 80+ chars are allowed for better readability. >> So, please don't do that. >> [ Checkpatch should not warn on this especially for comments. ] > > We almost always split long comments into separated lines in the > kernel. What's different with this case? >
1st it is not mandatory.
2nd it is more readable in one line.
- /* 4706 CC and PMU watchdogs are clocked at 1/4 of ALP clock */ + /* 4706 CC and PMU watchdogs are clocked at 1/4 of ALP + * clock + */
I agree with you when the comment would be longer.
- Sedat -
| |