Messages in this thread | | | Date | Thu, 25 Dec 2014 23:37:45 +0100 | From | Helge Deller <> | Subject | Re: [PATCH repost 12/16] parisc/uaccess: fix sparse errors |
| |
Hi Michael,
On 12/25/2014 10:29 AM, Michael S. Tsirkin wrote: > virtio wants to read bitwise types from userspace using get_user. At the
I don't know the virtio code much yet, but does it makes sense to read bitwise types? Will virtio then get possible troubles because of endianess correct as well?
Do you have a code example, or the sparse error message ?
Helge
> moment this triggers sparse errors, since the value is passed through an > integer. > > Fix that up using __force. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > arch/parisc/include/asm/uaccess.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/parisc/include/asm/uaccess.h b/arch/parisc/include/asm/uaccess.h > index a5cb070..3a20da6 100644 > --- a/arch/parisc/include/asm/uaccess.h > +++ b/arch/parisc/include/asm/uaccess.h > @@ -104,7 +104,7 @@ struct exception_data { > } \ > } \ > \ > - (x) = (__typeof__(*(ptr))) __gu_val; \ > + (x) = (__force __typeof__(*(ptr))) __gu_val; \ > __gu_err; \ > }) > >
| |