lkml.org 
[lkml]   [2014]   [Dec]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH repost 15/16] sparc/uaccess: fix sparse errors
    virtio wants to read bitwise types from userspace using get_user.  At the
    moment this triggers sparse errors, since the value is passed through an
    integer.

    Fix that up using __force.

    Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    ---
    arch/sparc/include/asm/uaccess_64.h | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/arch/sparc/include/asm/uaccess_64.h b/arch/sparc/include/asm/uaccess_64.h
    index c990a5e..b80866d 100644
    --- a/arch/sparc/include/asm/uaccess_64.h
    +++ b/arch/sparc/include/asm/uaccess_64.h
    @@ -145,7 +145,7 @@ case 2: __get_user_asm(__gu_val,uh,addr,__gu_ret); break; \
    case 4: __get_user_asm(__gu_val,uw,addr,__gu_ret); break; \
    case 8: __get_user_asm(__gu_val,x,addr,__gu_ret); break; \
    default: __gu_val = 0; __gu_ret = __get_user_bad(); break; \
    -} data = (type) __gu_val; __gu_ret; })
    +} data = (__force type) __gu_val; __gu_ret; })

    #define __get_user_nocheck_ret(data,addr,size,type,retval) ({ \
    register unsigned long __gu_val __asm__ ("l1"); \
    @@ -155,7 +155,7 @@ case 2: __get_user_asm_ret(__gu_val,uh,addr,retval); break; \
    case 4: __get_user_asm_ret(__gu_val,uw,addr,retval); break; \
    case 8: __get_user_asm_ret(__gu_val,x,addr,retval); break; \
    default: if (__get_user_bad()) return retval; \
    -} data = (type) __gu_val; })
    +} data = (__force type) __gu_val; })

    #define __get_user_asm(x,size,addr,ret) \
    __asm__ __volatile__( \
    --
    MST


    \
     
     \ /
      Last update: 2014-12-25 11:01    [W:4.904 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site