Messages in this thread | | | Date | Tue, 23 Dec 2014 21:14:31 -0500 | Subject | Re: [PATCH] incorrect use of init_completion fixup | From | Ed Cashin <> |
| |
On Tue, Dec 23, 2014 at 12:44 PM, Nicholas Mc Guire <der.herr@hofr.at> wrote: > > The second init_completion call should be a reinit_completion here. > > patch is against 3.18.0 linux-next > > Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at> > --- > drivers/block/aoe/aoecmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c > index 422b7d8..2239513 100644 > --- a/drivers/block/aoe/aoecmd.c > +++ b/drivers/block/aoe/aoecmd.c > @@ -1331,7 +1331,7 @@ aoe_ktstart(struct ktstate *k) > return -ENOMEM; > k->task = task; > wait_for_completion(&k->rendez); /* allow kthread to start */ > - init_completion(&k->rendez); /* for waiting for exit later */ > + reinit_completion(&k->rendez); /* for waiting for exit later */ > return 0; > }
That looks good to me, thanks.
-- Ed Cashin <ecashin@noserose.net>
| |