Messages in this thread Patch in this message | | | From | Paolo Bonzini <> | Subject | [PATCH v2] checkpatch: fix UNNECESSARY_KERN_LEVEL false positive | Date | Tue, 23 Dec 2014 14:31:25 +0100 |
| |
KERN_<LEVEL> is never redundant with printk_ratelimited or printk_once. (Except perhaps in the sense that you could use e.g. pr_err_ratelimited or pr_err_once, but that would apply to printk as well).
Cc: Andy Whitcroft <apw@canonical.com> Cc: Joe Perches <joe@perches.com> Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- v1->v2: skip printk_once too [Joe Perches]
scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index f0bb6d60c07b..350cd692a138 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -4545,7 +4545,7 @@ sub process { } # check for logging functions with KERN_<LEVEL> - if ($line !~ /printk\s*\(/ && + if ($line !~ /printk(?:_ratelimited|_once)?\s*\(/ && $line =~ /\b$logFunctions\s*\(.*\b(KERN_[A-Z]+)\b/) { my $level = $1; if (WARN("UNNECESSARY_KERN_LEVEL", -- 1.8.3.1
| |