| Date | Tue, 23 Dec 2014 02:45:51 -0800 | From | Christoph Hellwig <> | Subject | Re: [RFC PATCH 08/17] block: refactor __bio_copy_iov() |
| |
> static int __bio_copy_iov(struct bio *bio, const struct iov_iter *iter, > + int to_iov) > { > + int i; > struct bio_vec *bvec; > struct iov_iter iov_iter = *iter;
Why not pass the iov_iter by value?
> bio_for_each_segment_all(bvec, bio, i) { > + ssize_t ret; > + > + if (to_iov == WRITE) > + ret = copy_page_to_iter(bvec->bv_page, > + bvec->bv_offset, > + bvec->bv_len, > + &iov_iter); > + else > + ret = copy_page_from_iter(bvec->bv_page, > + bvec->bv_offset, > + bvec->bv_len, > + &iov_iter); > + > + if (!iov_iter_count(&iov_iter)) > + break; > > + if (ret < bvec->bv_len) > + return -EFAULT; > } > > + return 0;
Seems like this should be split into two functions for the read and write cases?
|