Messages in this thread | | | Date | Tue, 23 Dec 2014 02:23:45 -0800 | From | Christoph Hellwig <> | Subject | Re: [RFC PATCH 03/17] block: simplify issueing discard, write_same, zeroout |
| |
On Mon, Dec 22, 2014 at 12:48:30PM +0100, Dongsu Park wrote: > From: Kent Overstreet <kmo@daterainc.com> > > Simplify special cases for issueing discard, write_same, and zeroout, > replacing bio_batch completions with submit_bio_wait(). This conversion > is possible because generic_make_request() will now do for us what the > code in blk-lib.c was doing manually, with the bio_batch stuff. So we > still need some looping in case we're trying to discard/zeroout more > than around a gigabyte, but when we can submit that much at a time > doing the submissions in parallel really shouldn't matter.
Unless there this makes later patches simpler I don't see a good reason to remove this parallel submission for the gain of only about 100 less lines of code.
| |