Messages in this thread | | | Date | Mon, 22 Dec 2014 12:05:12 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] tools: perf: util: color.c: Remove some unused functions |
| |
Em Mon, Dec 22, 2014 at 03:56:10PM +0100, Jiri Olsa escreveu: > On Sat, Dec 20, 2014 at 01:51:05PM +0100, Rickard Strandqvist wrote: > > Removes some functions that are not used anywhere: > > color_parse_mem() color_parse() > > > > This was partially found by using a static code analysis program called cppcheck. > > and partially removed ;-) > > [jolsa@krava perf]$ make > BUILD: Doing 'make -j4' parallel build > CC util/debug.o > CC util/color.o > CC util/machine.o > CC util/map.o > util/color.c:8:12: error: ‘parse_color’ defined but not used [-Werror=unused-function] > static int parse_color(const char *name, int len) > ^ > util/color.c:28:12: error: ‘parse_attr’ defined but not used [-Werror=unused-function] > static int parse_attr(const char *name, int len) > ^ > cc1: all warnings being treated as errors > make[1]: *** [util/color.o] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [all] Error 2 > > > any clue why this (color name parsing) is in?
Humm, there is support for changing the TUI colors in ~/.perfconfig, but probably it doesn't uses those functions?
- Arnaldo
| |