Messages in this thread | | | Date | Mon, 22 Dec 2014 11:56:15 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] tools: perf: util: color.c: Remove some unused functions |
| |
Em Mon, Dec 22, 2014 at 11:53:58AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Dec 22, 2014 at 11:50:13AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Sat, Dec 20, 2014 at 01:51:05PM +0100, Rickard Strandqvist escreveu: > > > Removes some functions that are not used anywhere: > > > color_parse_mem() color_parse() > > > > > > This was partially found by using a static code analysis program called cppcheck. > > > > Thanks, applied. > > Take that back, can you please check this: > > [acme@ssdandy linux]$ am /wb/1.patch > Applying: tools: perf: util: color.c: Remove some unused functions > [perf/core b419f879f2a0] perf tools: Remove some unused functions from color.c > Author: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> > 2 files changed, 92 deletions(-) > [acme@ssdandy linux]$ time make -C tools/perf build-test > make: Entering directory `/home/acme/git/linux/tools/perf' > - make_pure: cd . && make -f Makefile DESTDIR=/tmp/tmp.4b0BVUu9ff > cd . && make -f Makefile DESTDIR=/tmp/tmp.4b0BVUu9ff > BUILD: Doing 'make -j8' parallel build > config/Makefile:390: No libunwind found. Please install libunwind-dev[el] >= 1.1 and/or set LIBUNWIND_DIR
Removed the now unused parse_{attr,color} static routines and I'm running 'make -C tools/perf build-test' again to see if all goes well.
- Arnaldo
| |