Messages in this thread | | | Date | Thu, 18 Dec 2014 10:19:06 +1100 | From | NeilBrown <> | Subject | Re: [PATCH] drivers:md: Remove no longer needed fixme comment in raid5.c |
| |
On Wed, 17 Dec 2014 10:49:33 -0500 Nicholas Krause <xerofoify@gmail.com> wrote:
> Removes the no longer needed fix me comment related to not needing the agrument faster for the function, > sync_request. Due to getting warnings when building without the agrument it seems that this fix me was > wrong and we must keep this agrument in order to avoid build warnings when building without it. > > Signed-off-by: Nicholas Krause <xerofoify@gmail.com> > --- > drivers/md/raid5.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c > index c1b0d52..c0fde2a 100644 > --- a/drivers/md/raid5.c > +++ b/drivers/md/raid5.c > @@ -4986,7 +4986,6 @@ ret: > return reshape_sectors; > } > > -/* FIXME go_faster isn't used */ > static inline sector_t sync_request(struct mddev *mddev, sector_t sector_nr, int *skipped, int go_faster) > { > struct r5conf *conf = mddev->private;
Why do you think the comment is no longer needed. Is "go_faster" being used now? Is there a clear explanation somewhere of why "go_faster" should not be used?
NeilBrown [unhandled content-type:application/pgp-signature] | |