lkml.org 
[lkml]   [2014]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: randconfig build error with next-20141210, in drivers/net/ethernet/broadcom/genet
From
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Thu, 11 Dec 2014 21:09:01 -0800

> Le 11/12/2014 11:22, David Miller a écrit :
>> From: Jim Davis <jim.epost@gmail.com> Date: Wed, 10 Dec 2014
>> 09:10:45 -0700
>>
>>> Building with the attached random configuration file,
>>>
>>> ERROR: "fixed_phy_register"
>>> [drivers/net/ethernet/broadcom/genet/genet.ko] undefined!
>>
>> Florian, I don't understand why FIXED_PHY is only selected in
>> Kconfig if the driver is statically built into the kernel.
>>
>> That makes no sense at all, you should need that module regardless
>> of how the driver itself is enabled.
>
> AFAIR this was introduced to silence a warning you reported:
>
> "I think you need to work on the Kconfig dependencies a little bit more.
> I have BCMGENET specified as modular, which absolutely should work. Yet
> Kconfig complains.
>
> warning: (BCMGENET) selects FIXED_PHY which has unmet direct
> dependencies (NETDEVICES && PHYLIB=y)"
>
> but I agree, this makes no sense, we should select FIXED_PHY
> unconditionnally, will send you patches tomorrow to fix that.

What's really perplexing is that FIXED_PHY is only enable'able
when PHYLIB=y. I think that's the core of the problems here.

All of these drivers shouldn't lose fixed phy support simply
because they, or PHYLIB itself, is built modular.


\
 
 \ /
  Last update: 2014-12-12 17:41    [W:0.078 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site