lkml.org 
[lkml]   [2014]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: randconfig build error with next-20141210, in drivers/net/ethernet/broadcom/genet
Le 11/12/2014 11:22, David Miller a écrit :
> From: Jim Davis <jim.epost@gmail.com> Date: Wed, 10 Dec 2014
> 09:10:45 -0700
>
>> Building with the attached random configuration file,
>>
>> ERROR: "fixed_phy_register"
>> [drivers/net/ethernet/broadcom/genet/genet.ko] undefined!
>
> Florian, I don't understand why FIXED_PHY is only selected in
> Kconfig if the driver is statically built into the kernel.
>
> That makes no sense at all, you should need that module regardless
> of how the driver itself is enabled.

AFAIR this was introduced to silence a warning you reported:

"I think you need to work on the Kconfig dependencies a little bit more.
I have BCMGENET specified as modular, which absolutely should work. Yet
Kconfig complains.

warning: (BCMGENET) selects FIXED_PHY which has unmet direct
dependencies (NETDEVICES && PHYLIB=y)"

but I agree, this makes no sense, we should select FIXED_PHY
unconditionnally, will send you patches tomorrow to fix that.

>
> Can't we just remove the "XXX=y" in all of those silly:
>
> select FIXED_PHY if XXX=y
>
> expressions?
>
> There are three such cases right now:
>
> drivers/net/dsa/Kconfig: select FIXED_PHY if NET_DSA_BCM_SF2=y
> drivers/net/ethernet/broadcom/Kconfig: select FIXED_PHY if
> BCMGENET=y drivers/net/ethernet/broadcom/Kconfig: select FIXED_PHY
> if SYSTEMPORT=y
>


--
Florian


\
 
 \ /
  Last update: 2014-12-12 06:41    [W:0.054 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site