lkml.org 
[lkml]   [2014]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 1/2] staging: media: lirc: lirc_zilog.c: fix quoted strings split across lines
On Wed, Dec 10, 2014 at 03:39:09PM -0800, Joe Perches wrote:
> On Wed, 2014-12-10 at 22:33 +0000, Luis de Bethencourt wrote:
> > checkpatch makes an exception to the 80-colum rule for quotes strings, and
> > Documentation/CodingStyle recommends not splitting quotes strings across lines
> > because it breaks the ability to grep for the string. Fixing these.
> []
> > diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c
> []
> > @@ -794,9 +796,9 @@ static int fw_load(struct IR_tx *tx)
> > if (!read_uint8(&data, tx_data->endp, &version))
> > goto corrupt;
> > if (version != 1) {
> > - dev_err(tx->ir->l.dev, "unsupported code set file version (%u, expected"
> > - "1) -- please upgrade to a newer driver",
> > - version);
> > + dev_err(tx->ir->l.dev,
> > + "unsupported code set file version (%u, expected 1) -- please upgrade to a newer driver",
> > + version);
>
> Unrelated but this one should have a '\n' termination
> at the end of the format.
>

I can add that change, no problem. As part of this patch or a third one?

Thanks for reviewing,
Luis


\
 
 \ /
  Last update: 2014-12-11 01:41    [W:0.120 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site