Messages in this thread Patch in this message | | | Subject | Re: [PATCH v4 1/2] staging: media: lirc: lirc_zilog.c: fix quoted strings split across lines | From | Joe Perches <> | Date | Wed, 10 Dec 2014 15:39:09 -0800 |
| |
On Wed, 2014-12-10 at 22:33 +0000, Luis de Bethencourt wrote: > checkpatch makes an exception to the 80-colum rule for quotes strings, and > Documentation/CodingStyle recommends not splitting quotes strings across lines > because it breaks the ability to grep for the string. Fixing these. [] > diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c [] > @@ -794,9 +796,9 @@ static int fw_load(struct IR_tx *tx) > if (!read_uint8(&data, tx_data->endp, &version)) > goto corrupt; > if (version != 1) { > - dev_err(tx->ir->l.dev, "unsupported code set file version (%u, expected" > - "1) -- please upgrade to a newer driver", > - version); > + dev_err(tx->ir->l.dev, > + "unsupported code set file version (%u, expected 1) -- please upgrade to a newer driver", > + version);
Unrelated but this one should have a '\n' termination at the end of the format.
| |