Messages in this thread Patch in this message | | | Subject | [PATCH] checkpatch: Add test for consecutive string fragments | From | Joe Perches <> | Date | Thu, 06 Nov 2014 22:39:59 -0800 |
| |
Emit a warning when single line string coalescing occurs.
Code that uses compiler string concatenation on a single line like: printk("foo" "bar"); is generally better to read concatenated like: printk("foobar");
Signed-off-by: Joe Perches <joe@perches.com> --- scripts/checkpatch.pl | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 893cbd5..508037a 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -4462,6 +4462,12 @@ sub process { "Concatenated strings should use spaces between elements\n" . $herecurr); } +# uncoalesced string fragments + if ($line =~ /"X*"\s*"/) { + WARN("STRING_FRAGMENTS", + "Consecutive strings are generally better as a single string\n" . $herecurr); + } + # warn about #if 0 if ($line =~ /^.\s*\#\s*if\s+0\b/) { CHK("REDUNDANT_CODE",
| |