Messages in this thread | | | Date | Fri, 7 Nov 2014 15:47:43 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v5 5/5] regulator: of: Add support for parsing initial and suspend modes |
| |
On Fri, Nov 07, 2014 at 02:00:05PM +0100, Javier Martinez Canillas wrote:
> + if (!of_property_read_u32(np, "regulator-initial-mode", &pval)) { > + if (desc && desc->map_modes) > + constraints->initial_mode = desc->map_modes(pval); > + else > + pr_warn("%s: failed to parse regulator-initial-mode\n", > + np->name); > + }
This is ignoring any error return from map_modes(), it's possible the DT might have an invalid value. The error message could also use some improvement, it's more that the kernel doesn't understand how to parse it even if it is valid. [unhandled content-type:application/pgp-signature] | |