lkml.org 
[lkml]   [2014]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 1/5] regulator: Document binding for initial and suspend modes
On Fri, Nov 07, 2014 at 02:00:01PM +0100, Javier Martinez Canillas wrote:

> + The "regulator-mode" property only takes effect if the regulator is
> + enabled for the given suspend state using "regulator-on-in-suspend".

Why?

> + If the regulator has not been explicitly disabled for the given state
> + with "regulator-off-in-suspend", then setting the operating mode
> + will also have no effect.

This seems surprising, I'd expect mode setting to be paid attention to
even if the regulator is off - we may add other ways to control the
enable state in suspend for example.

> +- regulator-initial-mode: initial operating mode. The set of possible operating
> + modes is the same used for the regulator-mode property and the device binding
> + documentation explains which property each regulator supports.
> +If no mode is defined, then the OS will not manage the modes and the hardware
> +default values will be used instead.

Again that seems surprising, it precludes any future changes and isn't
going to be true for devices where we can't read the current state.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-11-07 16:41    [W:0.097 / U:1.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site