Messages in this thread Patch in this message | | | From | Sudip Mukherjee <> | Subject | [PATCH] usbnet: smsc95xx: dereferencing NULL pointer | Date | Fri, 7 Nov 2014 18:52:40 +0530 |
| |
we were dereferencing dev to initialize pdata. but just after that we have a BUG_ON(!dev). so we were basically dereferencing the pointer first and then tesing it for NULL.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> --- drivers/net/usb/smsc95xx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c index d07bf4c..3393238 100644 --- a/drivers/net/usb/smsc95xx.c +++ b/drivers/net/usb/smsc95xx.c @@ -1670,12 +1670,13 @@ done: static int smsc95xx_resume(struct usb_interface *intf) { struct usbnet *dev = usb_get_intfdata(intf); - struct smsc95xx_priv *pdata = (struct smsc95xx_priv *)(dev->data[0]); + struct smsc95xx_priv *pdata; u8 suspend_flags = pdata->suspend_flags; int ret; u32 val; BUG_ON(!dev); + pdata = (struct smsc95xx_priv *)(dev->data[0]); netdev_dbg(dev->net, "resume suspend_flags=0x%02x\n", suspend_flags); -- 1.8.1.2
| |