Messages in this thread Patch in this message | | | From | Sudip Mukherjee <> | Subject | [PATCH] serial: MIPS: lantiq: use devm_iounmap instead of iounmap | Date | Thu, 6 Nov 2014 19:00:42 +0530 |
| |
port->membase was allocated using devm_ioremap_nocache, so ideally we should unmap it using devm_iounmap. but it was using iounmap.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> ---
hi, just a small problem here.I could not build test this as I do not have a MIPS crosscompiler.I know i should not send without a minimum build test, but this change should not break the build (or maybe i am wrong)..
drivers/tty/serial/lantiq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/lantiq.c b/drivers/tty/serial/lantiq.c index 4675fe1..18c3844 100644 --- a/drivers/tty/serial/lantiq.c +++ b/drivers/tty/serial/lantiq.c @@ -497,8 +497,10 @@ lqasc_type(struct uart_port *port) static void lqasc_release_port(struct uart_port *port) { + struct platform_device *pdev = to_platform_device(port->dev); + if (port->flags & UPF_IOREMAP) { - iounmap(port->membase); + devm_iounmap(&pdev->dev, port->membase); port->membase = NULL; } } -- 1.8.1.2
| |