Messages in this thread | | | Date | Thu, 6 Nov 2014 13:28:17 +0100 | From | Johan Hovold <> | Subject | Re: [PATCH v10 1/3] mfd: add support for Diolan DLN-2 devices |
| |
On Thu, Nov 06, 2014 at 01:45:46PM +0200, Octavian Purdila wrote: > On Wed, Nov 5, 2014 at 7:11 PM, Johan Hovold <johan@kernel.org> wrote: > > On Wed, Nov 05, 2014 at 07:04:59PM +0200, Octavian Purdila wrote: > >> This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO > >> Master Adapter DLN-2. Details about the device can be found here: > >> > >> https://www.diolan.com/i2c/i2c_interface.html. > >> > >> Information about the USB protocol can be found in the Programmer's > >> Reference Manual [1], see section 1.7. > >> > >> Because the hardware has a single transmit endpoint and a single > >> receive endpoint the communication between the various DLN2 drivers > >> and the hardware will be muxed/demuxed by this driver. > >> > >> Each DLN2 module will be identified by the handle field within the DLN2 > >> message header. If a DLN2 module issues multiple commands in parallel > >> they will be identified by the echo counter field in the message header. > >> > >> The DLN2 modules can use the dln2_transfer() function to issue a > >> command and wait for its response. They can also register a callback > >> that is going to be called when a specific event id is generated by > >> the device (e.g. GPIO interrupts). The device uses handle 0 for > >> sending events. > >> > >> [1] https://www.diolan.com/downloads/dln-api-manual.pdf > >> > >> Signed-off-by: Octavian Purdila <octavian.purdila@intel.com> > > > > Reviewed-by: Johan Hovold <johan@kernel.org> > > > > Just noticed checkpatch complains about two typos in the header file > > (since v9?). ;) > > > > Ah nice new checkpatch feature, I used checkpath before rebasing the > tree and missed those. I will fix the typos and submit v11 with your > review-by tags. Thanks a lot for your awesome reviews Johan !
You're welcome.
Johan
| |