Messages in this thread | | | Date | Wed, 5 Nov 2014 18:06:05 +0100 | From | Petr Mladek <> | Subject | Re: [RFC][PATCH 10/12 v3] seq-buf: Make seq_buf_bprintf() conditional on CONFIG_BINARY_PRINTF |
| |
On Tue 2014-11-04 10:52:47, Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org> > > The function bstr_printf() from lib/vsprnintf.c is only available if > CONFIG_BINARY_PRINTF is defined. This is due to the only user currently > being the tracing infrastructure, which needs to select this config > when tracing is configured. Until there is another user of the binary > printf formats, this will continue to be the case. > > Since seq_buf.c is now lives in lib/ and is compiled even without > tracing, it must encompass its use of bstr_printf() which is used > by seq_buf_printf(). This too is only used by the tracing infrastructure > and is still encapsulated by the CONFIG_BINARY_PRINTF. > > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Please switch the order and do this change before moving to lib/. IMHO, the current order would break bisecting when tracing is disabled.
Otherwise, the change looks good in itself, so:
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Best Regards, Petr
| |