Messages in this thread | | | Date | Wed, 5 Nov 2014 15:26:20 +0100 | From | Petr Mladek <> | Subject | Re: [RFC][PATCH 03/12 v3] tracing: Create seq_buf layer in trace_seq |
| |
On Tue 2014-11-04 10:52:40, Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org> > > Create a seq_buf layer that trace_seq sits on. The seq_buf will not > be limited to page size. This will allow other usages of seq_buf > instead of a hard set PAGE_SIZE one that trace_seq has. > > Signed-off-by: Steven Rostedt <rostedt@goodmis.org> > --- > include/linux/seq_buf.h | 72 ++++++++ > include/linux/trace_seq.h | 10 +- > kernel/trace/Makefile | 1 + > kernel/trace/seq_buf.c | 341 +++++++++++++++++++++++++++++++++++ > kernel/trace/trace.c | 39 ++-- > kernel/trace/trace_events.c | 6 +- > kernel/trace/trace_functions_graph.c | 6 +- > kernel/trace/trace_seq.c | 184 +++++++++---------- > 8 files changed, 534 insertions(+), 125 deletions(-) > create mode 100644 include/linux/seq_buf.h > create mode 100644 kernel/trace/seq_buf.c > > diff --git a/include/linux/seq_buf.h b/include/linux/seq_buf.h > new file mode 100644 > index 000000000000..97872154d51c > --- /dev/null > +++ b/include/linux/seq_buf.h > @@ -0,0 +1,72 @@ > +#ifndef _LINUX_SEQ_BUF_H > +#define _LINUX_SEQ_BUF_H > + > +#include <linux/fs.h> > + > +#include <asm/page.h>
One more small thing. We do not need this include because seq_buf does not use the PAGE_SIZE.
Best Regards, Petr
| |