Messages in this thread | | | Date | Tue, 04 Nov 2014 21:48:12 -0700 | From | Stephen Warren <> | Subject | Re: [PATCHv2 2/5] mmc: sdhci-bcm2835: make shift calculations consistent |
| |
On 10/30/2014 12:36 AM, Scott Branden wrote: > Make the shift calculations consistent rather than having different > implementations to calculate the same thing.
> diff --git a/drivers/mmc/host/sdhci-bcm2835.c b/drivers/mmc/host/sdhci-bcm2835.c
> +#define REG_OFFSET_IN_BITS(reg) ((reg) << 3 & 0x18)
This should really be the following so people don't have to memorize operator precedence:
#define REG_OFFSET_IN_BITS(reg) (((reg) << 3) & 0x18)
(I've been bit by people mis-remembering precedence in very similar code...)
| |