lkml.org 
[lkml]   [2014]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] input: stmpe: bias keypad columns properly
Hi Linus,

On Sat, Oct 18, 2014 at 02:56:39PM +0200, Linus Walleij wrote:
> + if (variant->set_pullup) {
> + u8 val;
> +
> + ret = stmpe_reg_read(stmpe, pureg);
> + if (ret)
> + return ret;
> +
> + /* Do not touch unused pins, may be used for GPIO */
> + val = ret & ~pu_pins;
> + val |= pu_pins;
> +
> + ret = stmpe_reg_write(stmpe, pureg, val);

Don't we need
if (ret) {
dev_err(...);
return ret;
}

here?

--
Dmitry


\
 
 \ /
  Last update: 2014-11-04 03:41    [W:0.055 / U:0.932 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site