Messages in this thread | | | Date | Mon, 3 Nov 2014 17:57:21 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH 3/3] input: stmpe: bias keypad columns properly |
| |
Hi Linus,
On Sat, Oct 18, 2014 at 02:56:39PM +0200, Linus Walleij wrote: > + if (variant->set_pullup) { > + u8 val; > + > + ret = stmpe_reg_read(stmpe, pureg); > + if (ret) > + return ret; > + > + /* Do not touch unused pins, may be used for GPIO */ > + val = ret & ~pu_pins; > + val |= pu_pins; > + > + ret = stmpe_reg_write(stmpe, pureg, val);
Don't we need if (ret) { dev_err(...); return ret; }
here?
-- Dmitry
| |