Messages in this thread | | | From | "Elliott, Robert (Server Storage)" <> | Subject | RE: [PATCH v4 4/7] x86, mm, pat: Add pgprot_writethrough() for WT | Date | Mon, 3 Nov 2014 22:10:39 +0000 |
| |
> -----Original Message----- > From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel- > owner@vger.kernel.org] On Behalf Of Kani, Toshimitsu > Sent: Monday, 27 October, 2014 5:56 PM > To: hpa@zytor.com; tglx@linutronix.de; mingo@redhat.com; akpm@linux- > foundation.org; arnd@arndb.de > Cc: linux-mm@kvack.org; linux-kernel@vger.kernel.org; > jgross@suse.com; stefan.bader@canonical.com; luto@amacapital.net; > hmh@hmh.eng.br; yigal@plexistor.com; konrad.wilk@oracle.com; Kani, > Toshimitsu > Subject: [PATCH v4 4/7] x86, mm, pat: Add pgprot_writethrough() for > WT > > This patch adds pgprot_writethrough() for setting WT to a given > pgprot_t. > > Signed-off-by: Toshi Kani <toshi.kani@hp.com> > Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> ... > diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c > index a214f5a..a0264d3 100644 > --- a/arch/x86/mm/pat.c > +++ b/arch/x86/mm/pat.c > @@ -896,6 +896,16 @@ pgprot_t pgprot_writecombine(pgprot_t prot) > } > EXPORT_SYMBOL_GPL(pgprot_writecombine); > > +pgprot_t pgprot_writethrough(pgprot_t prot) > +{ > + if (pat_enabled) > + return __pgprot(pgprot_val(prot) | > + cachemode2protval(_PAGE_CACHE_MODE_WT)); > + else > + return pgprot_noncached(prot); > +} > +EXPORT_SYMBOL_GPL(pgprot_writethrough); ...
Would you be willing to use EXPORT_SYMBOL for the new pgprot_writethrough function to provide more flexibility for modules to utilize the new feature? In x86/mm, 18 of 60 current exports are GPL and 42 are not GPL.
--- Rob Elliott HP Server Storage
| |