Messages in this thread | | | Date | Mon, 3 Nov 2014 10:01:50 -0800 | From | Guenter Roeck <> | Subject | Re: [PATCH 1/4] extcon: gpio: Convert the driver to use gpio desc API's |
| |
On Mon, Nov 03, 2014 at 10:32:27AM -0600, Felipe Balbi wrote: > From: George Cherian <george.cherian@ti.com> > > Convert the driver to use gpiod_* API's. > > Reviewed-by: Roger Quadros <rogerq@ti.com> > Signed-off-by: George Cherian <george.cherian@ti.com> > Signed-off-by: Sekhar Nori <nsekhar@ti.com> > Signed-off-by: Felipe Balbi <balbi@ti.com> > ---
I think it might be useful and appropriate to explain that and why you remove support for active-low pins, instead of hiding it in a seemingly unrelated patch.
Also, since you don't use the platform data flag anymore, you might as well remove it to give out-of-tree users a fair warning. Overall, it might be easier to just revert the patch introducing it (5bfbdc9caa7) before converting extcon to gpiod.
I am just glad that we stopped using extcon for other reasons ;-)
Guenter
| |