lkml.org 
[lkml]   [2014]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/2] ALSA: echoaudio: add reference of struct echoaudio
From
Date
On Mon, 2014-11-03 at 22:22 +0530, Sudip Mukherjee wrote:
> On Mon, Nov 03, 2014 at 07:08:08AM -0800, Joe Perches wrote:
[]
> > ftrace exists and is generic.
> >
> > Several of these seem to be function tracing
> > style uses and should just be deleted instead.
>
> function tracing style uses means?

ftrace

see:

Documentation/trace/ftrace.txt
Documentation/trace/ftrace-design.txt

> there are some prints which are printing the function name while printing the debug message.
> are those function tracing style uses??

A debug message should generally not be emitting a
message just for the sake of documenting when a
function is entered/left.

Sometimes that is useful for initial debugging, but
almost always those debugging printks should not be
left in the code that is pushed to kernel.org.




\
 
 \ /
  Last update: 2014-11-03 19:21    [W:0.382 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site