Messages in this thread | | | Date | Mon, 03 Nov 2014 16:18:58 +0100 | From | Takashi Iwai <> | Subject | Re: [PATCH v2 1/2] ALSA: echoaudio: add reference of struct echoaudio |
| |
At Mon, 03 Nov 2014 07:08:08 -0800, Joe Perches wrote: > > On Mon, 2014-11-03 at 15:17 +0100, Takashi Iwai wrote: > > At Mon, 3 Nov 2014 16:04:12 +0530, > > Sudip Mukherjee wrote: > > > > > > added reference of struct echoaudio to free_firmware function. > > > this structure will be later used to get a reference of the card > > > when converting snd_printk to dev_* in the next patch of the series. > > > > > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > > > > Thanks, now applied both. Though, I noticed that there is also a > > dev_notice() usage that should be also dev_dbg(). Corrected such > > lines in my side. > > Are any of these changes going to cause a > null pointer dereference of chip->card->dev?
All look OK at a quick glance. There was a recent change to make card->dev mandatory, so it's there from the very beginning.
> ftrace exists and is generic. > > Several of these seem to be function tracing > style uses and should just be deleted instead.
True. Further cleanup patches appreciated.
thanks,
Takashi
| |