Messages in this thread Patch in this message | | | From | Amos Kong <> | Subject | [PATCH v4 6/6] hw_random: don't init list element we're about to add to list. | Date | Mon, 3 Nov 2014 23:56:26 +0800 |
| |
From: Rusty Russell <rusty@rustcorp.com.au>
Another interesting anti-pattern.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> --- drivers/char/hw_random/core.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c index fc5de7d..b2cc8a1 100644 --- a/drivers/char/hw_random/core.c +++ b/drivers/char/hw_random/core.c @@ -493,7 +493,6 @@ int hwrng_register(struct hwrng *rng) goto out_unlock; } } - INIT_LIST_HEAD(&rng->list); list_add_tail(&rng->list, &rng_list); if (old_rng && !rng->init) { -- 1.9.3
| |