lkml.org 
[lkml]   [2014]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 4/6] hw_random: fix unregister race.
    On Mon, Nov 03, 2014 at 11:56:24PM +0800, Amos Kong wrote:
    >
    > @@ -98,6 +99,8 @@ static inline void cleanup_rng(struct kref *kref)
    >
    > if (rng->cleanup)
    > rng->cleanup(rng);

    You need a compiler barrier here to prevent reordering.

    > + rng->cleanup_done = true;

    Thanks,
    --
    Email: Herbert Xu <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


    \
     
     \ /
      Last update: 2014-11-10 15:21    [W:2.420 / U:0.276 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site