Messages in this thread | | | Date | Thu, 27 Nov 2014 15:29:43 +0100 | From | Alexander Graf <> | Subject | Re: [PATCH 1/3 v4] drivers/bus: Added Freescale Management Complex APIs |
| |
On 13.11.14 18:54, J. German Rivera wrote: > APIs to access the Management Complex (MC) hardware > module of Freescale LS2 SoCs. This patch includes > APIs to check the MC firmware version and to manipulate > DPRC objects in the MC. > > Signed-off-by: J. German Rivera <German.Rivera@freescale.com> > Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com>
[...]
> +/* > + * Object descriptor, returned from dprc_get_obj() > + */ > +struct dprc_obj_desc { > + /* Type of object: NULL terminated string */ > + char type[16];
I don't see where it actually gets NULL terminated - all 16 bytes come directly from the device.
While it's probably ok to trust it, I think we'd still be safer off if we just make this a char[17] array to always have our NULL terminating string. That way we're guaranteed we'll never run over our memory boundaries.
Also sorry for the slowly trickling in comments - I'm just noting things as I dig through the whole interface :).
Alex
| |