Messages in this thread | | | Date | Wed, 26 Nov 2014 12:35:49 -0600 | From | German Rivera <> | Subject | Re: [PATCH 1/3 v4] drivers/bus: Added Freescale Management Complex APIs |
| |
On 11/26/2014 04:15 AM, Alexander Graf wrote: > > > On 13.11.14 18:54, J. German Rivera wrote: >> APIs to access the Management Complex (MC) hardware >> module of Freescale LS2 SoCs. This patch includes >> APIs to check the MC firmware version and to manipulate >> DPRC objects in the MC. >> >> Signed-off-by: J. German Rivera <German.Rivera@freescale.com> >> Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com> > > [...] > [] >> + >> +int dprc_get_container_id(struct fsl_mc_io *mc_io, int *container_id) > > This one is definitely a misnomer. It's a command that operates on the > MC object, not a DPRC object. Also it doesn't fetch a random > "container_id", it fetches the root container id. > > Please move it and its definition to the files that operate on the MC > management interface. > Ok, I will make this change in respin v5.
Thanks,
German > > Alex >
| |