| Date | Tue, 18 Nov 2014 15:24:21 +0100 | From | Petr Mladek <> | Subject | Re: [PATCH 13/26 v5] tracing: Fix return value of ftrace_raw_output_prep() |
| |
On Fri 2014-11-14 23:59:00, Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org> > > If the trace_seq of ftrace_raw_output_prep() is full this function > returns TRACE_TYPE_PARTIAL_LINE, otherwise it returns zero. > > The problem is that TRACE_TYPE_PARTIAL_LINE happens to be zero! > > The thing is, the caller of ftrace_raw_output_prep() expects a > success to be zero. Change that to expect it to be > TRACE_TYPE_HANDLED. > > Link: http://lkml.kernel.org/r/20141114112522.GA2988@dhcp128.suse.cz > > Reminded-by: Petr Mladek <pmladek@suse.cz> > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Best Regards, Petr
|