Messages in this thread | | | Date | Mon, 17 Nov 2014 19:27:33 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH 20/26 v5] seq_buf: Add seq_buf_can_fit() helper function |
| |
On Mon, 17 Nov 2014 16:07:33 -0800 Joe Perches <joe@perches.com> wrote:
> On Mon, 2014-11-17 at 12:36 -0500, Steven Rostedt wrote: > > On Fri, 14 Nov 2014 23:59:07 -0500 > > Steven Rostedt <rostedt@goodmis.org> wrote: > > > > > From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org> > > > > > > Add a seq_buf_can_fit() helper function that removes the possible mistakes > > > of comparing the seq_buf length plus added data compared to the size of > > > the buffer. > [] > > > +static bool seq_buf_can_fit(struct seq_buf *s, size_t len) > > > +{ > > > + return s->len + len < s->size; > > > +} > > > + > > Why is this useful?
Places the logic in one place and makes the next patch much shorter.
As the change log states, makes mistakes much less likely to happen (note, I made one doing the next change and this makes me more confident not to do another one)
-- Steve
| |