Messages in this thread | | | Date | Mon, 17 Nov 2014 13:13:07 -0600 | From | Seth Jennings <> | Subject | Re: [PATCHv2 2/3] kernel: add support for live patching |
| |
On Mon, Nov 17, 2014 at 10:45:58AM -0800, Greg KH wrote: > On Sun, Nov 16, 2014 at 07:29:23PM -0600, Seth Jennings wrote: > > +#ifdef CONFIG_X86_32 > > +int lpc_write_module_reloc(struct module *mod, unsigned long type, > > + unsigned long loc, unsigned long value) > > +{ > > + pr_err("Live patching not supported on 32-bit x86\n"); > > + return -ENOSYS; > > +} > > Why not just prevent the code from being built on x86_32 instead of > putting this in the file?
Yep. Masami saw this too and recommended a ARCH_HAVE_LIVE_PATCHING flag set by the archs that support it. I'll make the change.
Thanks for the review!
Seth
> > thanks, > > greg k-h
| |